[PATCH] [POWERPC] Fix of_i2c include for module compilation
Jochen Friedrich
jochen at scram.de
Wed May 7 04:39:37 EST 2008
Hi Paul,
>> -#ifdef CONFIG_OF_I2C
>> +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE)
>>
>> void of_register_i2c_devices(struct i2c_adapter *adap,
>> struct device_node *adap_node);
>
> Why do we have that ifdef there at all? There's only that one
> external declaration within it, so the #ifdef and #endif could just be
> removed. If the ifdef hadn't been there in the first place we
> wouldn't have had this problem.
You're right. I mainly copied from of_gpio.h without too much thinking :(.
I'll resend.
Thanks,
Jochen
More information about the Linuxppc-dev
mailing list