[PATCH] Add support for Analogue & Micro ASP837E board

[Bryan O'Donoghue]

On Tue, 6 May 2008 16:11:10 +1000
Stephen Rothwell <sfr at canb.auug.org.au> wrote:

> Hi Bryan,
> 
> On Tue, 6 May 2008 03:28:13 +0100 Bryan O'Donoghue <bodonoghue at codehermit.ie>
> wrote:
> >
> > +static void __init asp834x_init_IRQ(void)
> > +{
> > +	struct device_node *np;
> > +
> > +	np = of_find_node_by_type(NULL, "ipic");
> > +	if (!np)
> > +		return;
> > +
> > +	ipic_init(np, 0);
> 
> You need an "of_node_put(np)" here to drop the reference gained in
> "of_find_node_by_type".
> 
> > +static struct of_device_id asp8347_ids[] = {
> 
> Please make this __initdata.
> 

Hey Stephen.

Thanks for spotting that. Will do.


Cheers,
Bryan