[PATCH 4/4] booting-without-of for Freescale MSI

[Jin Zhengxiong]

> 
> > +    - compatible : should be "fsl,MPIC-MSI" for 85xx/86xx cpu,
> > +      and "fsl,IPIC-MSI" for 83xx cpu.
> 
> Please use a more specific name, "fsl,8599-msi" or similar?
>

Thanks for your input. I think the name "fsl,MPIC-MSI" and
"fsl,IPIC-MSI"
is somethind specific. Actually, from the hardware point,  MSI is just
part
of MPIC of IPIC for Freescale CPU. the name "fsl,MPIC-MSI" can describe
the MSI is based on the MPIC controller.
 
> > +    - interrupts : should contain the msi interrupts cascade to the
> > host
> > +      interrupt controller.
> 
> You should describe that it is one "interrupts" entry per 32 
> MSIs; also, it would be nice to say they need "0" as the sense.
> 
> > +    - interrupt-parent: should be "&mpic" for 85xx/86xx cpu and
> > "&ipic"
> > +      for 83xx cpu.
> 
> &Xpic are labels, so something local to specific DTS files; 
> instead, say that the interrupts are routed to the MPIC/IPIC 
> (it doesn't have to be via "interrupt-parent", either).
> 
Thank you, I'll rewrite these description. 


> Segher
> 
> p.s. On a meta-note, please put the binding doc first in the 
> series, it makes things easier to review in-order.

Ok, I'll put it first next time.

Jason