[PATCH 1/4] [v4][POWERPC] refactor dcr code

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue May 6 14:02:11 EST 2008


On Tue, 2008-05-06 at 13:40 +1000, Stephen Rothwell wrote:
> Since find_dcr_parent has done a of_node_get on its return value, you
> leak a reference to dp here i.e. you need an of_node_put(dp) before
> you return.

He inherited that bug from other dcr.c functions I wrote, my fault.

Stephen (N. not R.), would you mind fixing them while at it or do you
want me to cook up a patch ?

Cheers,
Ben.





More information about the Linuxppc-dev mailing list