[PATCH] Sam440ep support

Josh Boyer jwboyer at linux.vnet.ibm.com
Tue May 6 10:09:23 EST 2008


On Tue, 06 May 2008 09:40:05 +1000
Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

> 
> On Mon, 2008-05-05 at 13:54 -0500, Josh Boyer wrote:
> > > +arch_initcall(sam440ep_i2c_of_init);
> > 
> > Ok, now I'm confused as to why you aren't doing this in your platform
> > file (which would make it specific, and therefore justify its
> > existence.
> 
> I addition, that gets called on all platforms, not only sam440ep, which
> is wrong.

Correct.  I was starting with code organization vs. specific comments
since it was all one big patch.  I'll get into details when it gets
split properly :).

josh



More information about the Linuxppc-dev mailing list