[PATCH] [POWERPC] Fix bootwrapper builds with newer gcc versions

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat May 3 09:27:55 EST 2008


On Fri, 2008-05-02 at 14:40 -0700, David Miller wrote:
> From: Kumar Gala <galak at kernel.crashing.org>
> Date: Fri, 2 May 2008 16:28:36 -0500
> 
> > Sorry, I meant the gcc patch.  I'm not sure if this has been committed  
> > to FSF head or not.
> 
> If that's the case it would be a good idea to suggest a command line
> option to disable the new out-of-line code generation feature of that
> patch.
> 
> But if the stubs it calls are really simple, you can just add
> implementations under arch/powerpc/lib/, and therefore it's
> not such a big deal.  This is what we've traditionally done
> with libcalls generated by gcc for runtime support.

My only worry with this is modules.

That is, it would be fairly non-sensical for module code to go through
the trampoline to call those stubs in the kernel (and having to
EXPORT_SYMBOL them).

In the case of those register save stubs, I believe they should really
be linked with the modules.

Ben.





More information about the Linuxppc-dev mailing list