[PATCH v2.6.26] powerpc: Fix a bunch of sparse warnings in the qe_lib
Timur Tabi
timur at freescale.com
Sat May 3 04:37:13 EST 2008
Andy Fleming wrote:
> int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** uccf_ret)
> {
> struct ucc_fast_private *uccf;
> - struct ucc_fast *uf_regs;
> + struct ucc_fast __iomem *uf_regs;
> u32 gumr;
> int ret;
>
> @@ -216,10 +216,10 @@ int ucc_fast_init(struct ucc_fast_info * uf_info, struct ucc_fast_private ** ucc
> uccf->stopped_tx = 0;
> uccf->stopped_rx = 0;
> uf_regs = uccf->uf_regs;
> - uccf->p_ucce = (u32 *) & (uf_regs->ucce);
> - uccf->p_uccm = (u32 *) & (uf_regs->uccm);
> + uccf->p_ucce = (u32 __iomem *) & (uf_regs->ucce);
> + uccf->p_uccm = (u32 __iomem *) & (uf_regs->uccm);
Since you've already made uf_regs into an __iomem pointer, do you really need to
cast it?
And please remember to CC: me on any QE library patches.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the Linuxppc-dev
mailing list