[PATCH 5/6] [POWERPC] Move device_to_mask() to dma-mapping.h

Mark Nelson markn at au1.ibm.com
Fri May 2 09:47:47 EST 2008


On Thu, 1 May 2008 07:04:30 pm Segher Boessenkool wrote:
> > Move device_to_mask() to dma-mapping.h because we need to use it from
> > outside dma_64.c in a later patch.
> 
> Why does this need to become an inline function?
> 
> 
> Segher
> 

I'm not sure exactly what you mean - it was inline before the move.

But, I honestly didn't think about it too much (although I possibly should
have)... I figured that it was static inline before my patch so I should leave
it as such.

But if everybody thinks it would be better to leave it in dma_64.c and just
expose it for use outside, I'm fine with that.

Thanks!

Mark.



More information about the Linuxppc-dev mailing list