[patch 1/5] POWERPC: Fix slb.c compile warnings

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu May 1 09:01:41 EST 2008


On Wed, 2008-04-30 at 15:24 -0700, Geoff Levand wrote:
> Arrange for a syntax check to always be done on the powerpc/mm/slb.c
> DBG() macro by defining it to pr_debug() for non-debug builds. 
> 
> Also, fix these related compile warnings:
> 
>   slb.c:273: warning: format '%04x' expects type 'unsigned int', but argument 2 has type 'long unsigned int
>   slb.c:274: warning: format '%04x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
> 
> Signed-off-by: Geoff Levand <geoffrey.levand at am.sony.com>

Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

> ---
>  arch/powerpc/mm/slb.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- a/arch/powerpc/mm/slb.c
> +++ b/arch/powerpc/mm/slb.c
> @@ -30,7 +30,7 @@
>  #ifdef DEBUG
>  #define DBG(fmt...) udbg_printf(fmt)
>  #else
> -#define DBG(fmt...)
> +#define DBG pr_debug
>  #endif
>  
>  extern void slb_allocate_realmode(unsigned long ea);
> @@ -279,8 +279,8 @@ void slb_initialize(void)
>  		patch_slb_encoding(slb_compare_rr_to_size,
>  				   mmu_slb_size);
>  
> -		DBG("SLB: linear  LLP = %04x\n", linear_llp);
> -		DBG("SLB: io      LLP = %04x\n", io_llp);
> +		DBG("SLB: linear  LLP = %04lx\n", linear_llp);
> +		DBG("SLB: io      LLP = %04lx\n", io_llp);
>  	}
>  
>  	get_paca()->stab_rr = SLB_NUM_BOLTED;
> 




More information about the Linuxppc-dev mailing list