[PATCH v2 4/6] [POWERPC] QE: implement support for the GPIO LIB API

Timur Tabi timur at freescale.com
Thu May 1 08:50:42 EST 2008

Anton Vorontsov wrote:

> Per Grant Likely's comments, "fsl,qe-pario-bank" considered as a made up
> stuff. MPC8323 is the first QE chip, so every next QE chips should be
> compatible.


>> Return value should be "u32", not "int".
> gpio.h disagree
> $ cat include/asm-generic/gpio.h  | grep \*get
>         int                     (*get)(struct gpio_chip *chip,

In that case, perhaps you should return this:

	return in_be32(&regs->cpdata) & pin_mask ? 1 : 0;

Timur Tabi
Linux kernel developer at Freescale

More information about the Linuxppc-dev mailing list