[PATCH 1/7] Implement arch disable/enable irq hooks.

Scott Wood scottwood at freescale.com
Thu May 1 07:07:45 EST 2008


On Wed, Apr 30, 2008 at 11:01:47PM +0200, Segher Boessenkool wrote:
> >>3. The style in all the assembly code is not to have spaces after
> >>commas separating instruction operands.
> >
> >I'll do that if that's what is prefered, but how did that come about as
> >the style used?  It's different from what we do in C,
> 
> But this isn't C code, it's assembler code.

Enh.  It's a comma-delineated list in both cases.

> PowerPC assembler code (and most other assembler code) doesn't use
> spaces here usually.

Looking at other arches, it seems pretty evenly split.

> >and adding the space helps readability in asm as well...
> 
> Many people disagree ;-)

Compressionhelpsreadability?

> Anyway, it's better to keep a consistent style, whatever that style
> is, don't you agree?

Not if it's GNU-style. :-)

-Scott



More information about the Linuxppc-dev mailing list