[PATCH] Make pasemi_mac.c depend on PPC_PASEMI to prevent link errors

Jeff Garzik jeff at garzik.org
Sat Mar 29 12:53:57 EST 2008


Michael Ellerman wrote:
> drivers/net/pasemi_mac.c is enabled by CONFIG_PASEMI_MAC, which depends on
> PPC64 && PCI. However pasemi_mac.c uses several routines that are only
> built when PPC_PASEMI is selected. This can lead to an unbuildable config:
> 
>  ERROR: ".pasemi_dma_start_chan" [drivers/net/pasemi_mac.ko] undefined!
> 
> So make CONFIG_PASEMI_MAC depend on PPC_PASEMI instead of PPC64.
> 
> Signed-off-by: Michael Ellerman <michael at ellerman.id.au>
> ---
>  drivers/net/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> 
> Jeff, pending Olof's ack, this would be nice for 25, but is obviously
> not super important.
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index fe7b5ec..3a0b20a 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2635,7 +2635,7 @@ config NIU
>  
>  config PASEMI_MAC
>  	tristate "PA Semi 1/10Gbit MAC"
> -	depends on PPC64 && PCI
> +	depends on PPC_PASEMI && PCI
>  	select PHYLIB

applied





More information about the Linuxppc-dev mailing list