[PATCH] [POWERPC] 4xx: Create common ppc4xx_reset_system() in ppc4xx_soc.c

Josh Boyer jwboyer at linux.vnet.ibm.com
Fri Mar 28 11:39:25 EST 2008


On Fri, 28 Mar 2008 10:56:18 +1100
David Gibson <david at gibson.dropbear.id.au> wrote:

> On Thu, Mar 27, 2008 at 03:43:31PM +0100, Stefan Roese wrote:
> > This patch creates a common system reset routine for all 40x and 44x
> > systems. Previously only a 44x routine existed. But since this system
> > reset via the debug control register is common for 40x and 44x let's
> > share this code for all those platforms in ppc4xx_soc.c.
> 
> Well... they're sort of common.  The source looks the same, but the
> SPR number of DBCR0 is different on 40x and 44x, which is a
> potentially serious gotcha.

Except that since 40x and 44x should never be built into the same
kernel.  So the #defines for DBCR0 should be picked correctly from
reg_booke.h.

I thought about that too, but I can't see where it will be an issue in
practice.

josh



More information about the Linuxppc-dev mailing list