[PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

Laurent Pinchart laurentp at cse-semaphore.com
Thu Mar 27 20:26:51 EST 2008


On Wednesday 26 March 2008 16:34, Segher Boessenkool wrote:
> >>>      {
> >>> +        .compatible    = "physmap-ram",
> >>> +        .data        = (void *)"map_ram",
> >>> +    },
> >>> +    {
> >>> +        .compatible    = "physmap-rom",
> >>> +        .data        = (void *)"map_rom",
> >>> +    },
> >
> >> Why the cast?  It's redundant afaics.
> >
> >   To be in line with the surrounding code...
> 
> I see _that_, but it's not a great argument IMNSHO.  Could I trick
> you into preceding this patch with a cleanup patch for the existing
> casts?

Ok. I'll submit a new patch as soon as we agree on a compatible name.

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussée de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75



More information about the Linuxppc-dev mailing list