[PATCH] scanlog_init cleanup, minor fixes

[Michael Ellerman]

On Wed, 2008-03-26 at 18:09 -0500, Nathan Lynch wrote:
> Michael Ellerman wrote:
> > > +	/* Ideally we could allocate a buffer < 4G */
> > > +	data = kzalloc(RTAS_DATA_BUF_SIZE, GFP_KERNEL);
> > > +	if (!data)
> > > +		goto err;
> > 
> > Not your bug, but what happens if data is > 4G? Kaboom?
> 
> An old RPA doc (scan-log-dump isn't specified in PAPR) says the buffer
> should be "contiguous real storage", so... yeah, probably.  That's why
> I preserved the comment.  Will fix if I get access to a machine to
> test this code more thoroughly (plenty of other issues in this file,
> too).

Cool, no point changing it if we can't test it.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080327/51b1ce3e/attachment.pgp>