[PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.

Segher Boessenkool segher at kernel.crashing.org
Thu Mar 27 02:34:58 EST 2008


>>>      {
>>> +        .compatible    = "physmap-ram",
>>> +        .data        = (void *)"map_ram",
>>> +    },
>>> +    {
>>> +        .compatible    = "physmap-rom",
>>> +        .data        = (void *)"map_rom",
>>> +    },
>
>> Why the cast?  It's redundant afaics.
>
>   To be in line with the surrounding code...

I see _that_, but it's not a great argument IMNSHO.  Could I trick
you into preceding this patch with a cleanup patch for the existing
casts?


Segher




More information about the Linuxppc-dev mailing list