[PATCH] cpm_uart: Allocate DPRAM memory for SMC ports onCPM2-based platforms.

Rune Torgersen runet at innovsys.com
Wed Mar 26 03:41:27 EST 2008


Laurent Pinchart wrote:
> On Tuesday 25 March 2008 17:27, Rune Torgersen wrote:
>>> Laurent Pinchart wrote:
>>> On Tuesday 25 March 2008 17:03, Scott Wood wrote:
>>>> Yes, I've answered questions on the lists from at least one person
>>>> using a custom board with cpm2 smc.
>>> 
>>> Are you sure it wasn't me ? ;-)
>> 
>> Probably me, actually. We have a 8280 with SMC's in use (SMC1 and 2)
> Do you have any opinion about the proposed patch ?

That is about time... :)
I've never really liked that the smc driver in the kernel relies on
parts of the SMC port to be set up by the boot-loader.
It really bit us when we were porting to 2.6.24, and was trying to
enable SMC2, since it was not used by u-boot as a console port, the pram
was uninitialized, and the linux driver then completely borked both
smc's.

This should take care of that, it looks like.

No driver should rely on the boot loader to initialize the device...
(With the exception of pin mappinmgs, PCI and memory...)



More information about the Linuxppc-dev mailing list