[RESEND] [PATCH 1/2 v2] [OF] Add of_device_is_available function

Josh Boyer jwboyer at linux.vnet.ibm.com
Tue Mar 25 22:51:58 EST 2008


On Tue, 25 Mar 2008 00:47:53 -0400
Sean MacLennan <smaclennan at pikatech.com> wrote:

> On Mon, 24 Mar 2008 22:39:18 +1100
> "Paul Mackerras" <paulus at samba.org> wrote:
> 
> > The second test will succeed for anything that starts with "ok", so
> > the first test is redundant.  I suspect you want strcmp instead of
> > strncmp in both tests.
> 
> I like the strncmp(status, "ok", 2). Then you can have a status of
> okey-dokey ;)

You can also have "oklahoma", "okaly-dokaly-do" (I hate Ned Flanders),
and "ok-this-device-is-fubar-don't-ever-touch-it!"

We really want just "okay" and "ok".  Look for a version 3 of the patch
that fixes it later today.

josh



More information about the Linuxppc-dev mailing list