[PATCH 1/2 v2] [POWERPC] Add PPC4xx L2-cache support (440GX)

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Mar 25 07:59:15 EST 2008


On Mon, 2008-03-24 at 08:39 -0500, Josh Boyer wrote:
> > +
> > +     local_irq_save(flags);
> > +     asm volatile ("sync" ::: "memory");
> 
> Perhaps just call iosync() for these instead of the open coded asm
> volatile stuff?

Not sure about that. iosync() will do a sync but it's not meant at being
used for things unrelated to IOs (and who knows... we might make it do
something else one day ?).

In low level arch code like that, an open coded sync might be proper
especially if it matches some documented sequence.

Cheers,
Ben.




More information about the Linuxppc-dev mailing list