[PATCH v2] 8xx: Add support for the MPC852 based board from keymile.

[Stephen Rothwell]

Hi Heiko,

On Fri, 14 Mar 2008 10:24:30 +0100 Heiko Schocher <hs at denx.de> wrote:
>
> This add support of the mgsuvd board from keymile to
> arch/powerpc. Supported SMC1 (serial console),
> SCC3 Ethernet (10Mbps hdx)

Paul would probably like some description of the board here.

> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
>
> +extern void cpm_reset(void);

This declaration is in asm/cpm1.h

> +struct cpm_pin {
> +		int port, pin, flags;
> +};

I wish someone would consolidate all these definitions of cpm_pin.

> +static void __init init_ioports(void)
> +{
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(mgsuvd_pins); i++) {
> +		struct cpm_pin *pin = &mgsuvd_pins[i];
> +		cpm1_set_pin(pin->port, pin->pin, pin->flags);
> +	}

And the code that uses them ...

> +static void __init mgsuvd_setup_arch(void)
> +{
> +	struct device_node *cpu;
> +
> +	cpu = of_find_node_by_type(NULL, "cpu");
> +	if (cpu != 0) {

"cpu" is a pointer, so "cpu != NULL" or just "cpu"

> +		const unsigned int *fp;
> +
> +		fp = of_get_property(cpu, "clock-frequency", NULL);
> +		if (fp != 0)

Ditto for "fp" test

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080315/13a20b40/attachment.pgp>