[PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

Paul Mackerras paulus at samba.org
Fri Mar 14 16:19:19 EST 2008


Manish Ahuja writes:

> If Mike and Paul are okay, then I will leave this bit as is and fix all 
> other issues and comments.

Well, part of the problem is the semantic dissonance caused by having
a static variable called "global".  Please change the name
"phyp_dump_global" to "phyp_dump_vars" or something similar - that
will only affect two lines of code and will reduce the ugliness a bit.

Paul.



More information about the Linuxppc-dev mailing list