[PATCH] [POWERPC] Fix viodasd driver with scatterlist debug

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Mar 12 17:52:42 EST 2008


On Wed, 2008-03-12 at 17:44 +1100, Stephen Rothwell wrote:
> Hi Ben,
> 
> On Wed, 12 Mar 2008 17:23:56 +1100 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> >
> > The iSeries viodasd drivers does some very strange things with
> > scatterlists, one of these causing a BUG_ON to trigger when
> > scatterlist debugging is enabled due to initializing the
> > scatterlist with memset instead of sg_init_table().
> > 
> > This fixes it by using sg_init_table(). The rest of the stuff
> > it does to that poor list is still pretty awful but it will work.
> 
> Presumably this is also needed in 2.6.24.xx

Possibly, though the problem only occurs when enabling scatterlist
debug, which distros don't do. Is it worth putting in a stable release ?

If yes, I'll submit it as soon as it hits upstream.

Cheers,
Ben.





More information about the Linuxppc-dev mailing list