ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()
Darrick J. Wong
djwong at us.ibm.com
Tue Mar 11 05:13:19 EST 2008
On Mon, Mar 10, 2008 at 10:59:43AM +0100, Roel Kluin wrote:
> > The & 0xff here is bogus anyway; temp is only ever used as an u8,
> > so just declare it as that, or do proper overflow/underflow checking
> > on it. The patch will need testing on hardware too, since it changes
> > behaviour (it should be a bugfix, but who knows).
> Maybe someone can test this?
I did. No regressions observed and it fixes that bug as well. Sorry I
didn't catch it earlier... :/
Acked-by: Darrick J. Wong <djwong at us.ibm.com>
More information about the Linuxppc-dev