[Patch] 8xx: MGSUVD support

[Stephen Rothwell]

Hi Heiko,

Just a few small comments.

On Sun, 09 Mar 2008 10:56:29 +0100 Heiko Schocher <hs at denx.de> wrote:
>
> +++ b/arch/powerpc/platforms/8xx/mgsuvd.c
>
> +#include <asm/of_platform.h>

You should include linux/of_platform.h (not asm/)

> +static struct cpm_pin mgsuvd_pins[] = {

Make this __initdata, please.

> +	ROOT_DEV = Root_NFS;

I am not sue we do this explicitly any more ... hopefully someone else
will comment.

> +static struct of_device_id __initdata of_bus_ids[] = {

Make this __initdata, please.

> +static int __init declare_of_platform_devices(void)
> +{
> +	if (!machine_is(mgsuvd))
> +		return 0;
> +
> +	of_platform_bus_probe(NULL, of_bus_ids, NULL);
> +
> +	return 0;
> +}
> +device_initcall(declare_of_platform_devices);

This should be "machine_device_initcall(mgsuvd,
declare_of_platform_devices);" then you don't need the machine_is() check
above.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080310/4eaff389/attachment.pgp>