[PATCH] PowerPC 4xx: Add dcri_clrset() for locked read/modify/write functionality

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Mar 6 22:50:37 EST 2008


On Thu, 2008-03-06 at 14:31 +0300, Valentine Barshak wrote:
> Josh Boyer wrote:
> > On Thu, 06 Mar 2008 11:06:18 +1100
> > Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> > 
> >> On Wed, 2008-03-05 at 21:38 +0300, Valentine Barshak wrote:
> >>> This adds dcri_clrset() macro which does read/modify/write
> >>> on indirect dcr registers while holding indirect dcr lock.
> >>>
> >>> Signed-off-by: Valentine Barshak <vbarshak at ru.mvista.com>
> >> Acked-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> > 
> > Indeed, looks good.  Valentine, are you going to rework your EMAC patch
> > to use this?
> > 
> > josh
> 
> Yes, I was going to update the pcie stuff and rework the emac patches.

The PCIe stuff is less of an issue as it happens early during boot,
there should be no race there, but it's still a good idea in the long
run. The EMAC bits look more like that kind of stuff we should have
ready asap for linux-next.

Cheers,
Ben.





More information about the Linuxppc-dev mailing list