[PATCH 11/17] Add memory mapping driver to RapidIO.

[Stephen Rothwell]

On Wed,  5 Mar 2008 00:29:56 +0800 Zhang Wei <wei.zhang at freescale.com> wrote:
>
> +	if (!(rmem->virt = dma_alloc_coherent(NULL, rmem->size,
> +				&rmem->iores.start, GFP_KERNEL))) {

Please separate assignments from tests.

> +	if ((ret = rio_space_claim(rmem))) {

Again.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080304/28f418be/attachment.pgp>