[PATCH 06/17] Change the kernel configurated RapidIO system size to auto-probing.

[Stephen Rothwell]

On Wed,  5 Mar 2008 00:29:51 +0800 Zhang Wei <wei.zhang at freescale.com> wrote:
>
> +	if (!(rionet_active = (struct rio_dev **)__get_free_pages(GFP_KERNEL,
> +				mport->sys_size ? __ilog2(sizeof(void *)) + 4
> +				: 0))) {

Please separate the assignment from the test.

> +		if (!(rswitch->route_table = kzalloc(sizeof(u8)*
> +					RIO_MAX_ROUTE_ENTRIES(port->sys_size),
> +					GFP_KERNEL))) {

Again.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080304/da366225/attachment.pgp>