[PATCH 1/2] firewire: endianess fix
Stefan Richter
stefanr at s5r6.in-berlin.de
Sat Mar 1 23:36:05 EST 2008
On 23 Feb, I wrote:
>> This needs to be tested on different big endian PCs, if possible with
>> the Apple Uninorth FireWire controller and other types of controllers.
I tested it myself now with VT6306 on PPC32.
> it should be triggered by replacing
> &fw_high_memory_region
> by
> &fw_private_region
> in drivers/firewire/fw-sbp2.c and testing with any SBP-2 device
This indeed demonstrates the fix. Any IO to SBP-2 devices fails with
timeouts. Just removing the posted write enable bit in fw-ohci wasn't
sufficient to catch it though. Maybe the controller has write posting
enabled by default.
However, this endianess bug was low-profile because there are currently
no kernelspace or userspace drivers for the firewire stack which need to
respond in split transactions.
--
Stefan Richter
-=====-==--- --== ----=
http://arcgraph.de/sr/
More information about the Linuxppc-dev
mailing list