[PATCH 0/4] Add Emerson KSI8560 board support

Paul Mackerras paulus at samba.org
Sat Mar 1 18:51:06 EST 2008


Alexandr Smirnov writes:

>    I've fixed the code according to your comments.

None of the patches you sent have any patch description or commentary,
and that's not good enough.  Yes, it all might be completely clear and
obvious in your head as to what the KSI8560 is and why you have made
the various design decisions you have, but it isn't necessarily
obvious to other people, and you yourself probably won't remember in
two years' time.  So write a paragraph or two for each patch telling
us those sort of things.

I concede that patches that just add a defconfig or a dts often don't
need much of a description, although even then there may be choices
made where you could usefully give us a rationale in the patch
description.

Paul.



More information about the Linuxppc-dev mailing list