[PATCH] of: i2c: improve last resort compatible entry selection

Segher Boessenkool segher at kernel.crashing.org
Mon Jul 28 17:47:21 EST 2008


>>  A reasonable "compatible" value would be something like
>> "serial-eeprom-24c32".
>>  You can go a little bit more generic than that, if you write up in
>>  your binding how the driver should figure out the device size and
>>  the protocol used.
>
> Matching on "serial-eeprom-24c32" requires me to convince the at24
> authors to add that string as an alias binding for their driver.

No, it requires the IIC subsystem to get fixed and not use OF
"compatible" values as module alias names.

> How
> about "serial-eeprom,24c32" or "generic,24x32"?

Neither "serial-eeprom" nor "generic" is the name of a vendor, so
no.  The comma has a well-defined meaning.  Why would a comma be
easier than a dash for your device matching code, anyway?


Segher




More information about the Linuxppc-dev mailing list