[PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()
David Miller
davem at davemloft.net
Mon Jul 28 05:56:04 EST 2008
From: Alan Cox <alan at lxorguk.ukuu.org.uk>
Date: Sun, 27 Jul 2008 18:27:09 +0100
> On Mon, 28 Jul 2008 02:37:32 +1000
> Stephen Rothwell <sfr at canb.auug.org.au> wrote:
>
> > On powerpc (allyesconfig build) we get this error:
> >
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> >
> > Signed-off-by: Stephen Rothwell <sfr at canb.auug.org.au>
>
> Can we please not merge new virt_to_bus users and instead fix the actual
> code to use the right functions?
Yes, please.
IMHO, this driver was really rushed in and that was a huge mistake.
If it had gone through linux-next we could have tidied all of this
stuff up in a less "rushed" manner.
More information about the Linuxppc-dev
mailing list