[PATCH 1/2] leds: make the default trigger name const

[Grant Likely]

On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote:
> The default_trigger fields of struct gpio_led and thus struct led_classdev
> are pretty much always assigned from a string literal, which means the
> string can't be modified.  Which is fine, since there is no reason to
> modify the string and in fact it never is.
> 
> But they should be marked const to prevent such code from being added, to
> prevent warnings if -Wwrite-strings is used and when assigned from a
> constant string other than a string literal (which produces a warning under
> current kernel compiler flags), and for general good coding practices.
> 
> Signed-off-by: Trent Piepho <tpiepho at freescale.com>
Acked-by: Grant Likely <grant.likely at secretlab.ca>
> ---
>  include/linux/leds.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/leds.h b/include/linux/leds.h
> index 519df72..defe693 100644
> --- a/include/linux/leds.h
> +++ b/include/linux/leds.h
> @@ -48,7 +48,7 @@ struct led_classdev {
>  
>  	struct device		*dev;
>  	struct list_head	 node;			/* LED Device list */
> -	char			*default_trigger;	/* Trigger to use */
> +	const char		*default_trigger;	/* Trigger to use */
>  
>  #ifdef CONFIG_LEDS_TRIGGERS
>  	/* Protects the trigger data below */
> @@ -121,7 +121,7 @@ extern void ledtrig_ide_activity(void);
>  /* For the leds-gpio driver */
>  struct gpio_led {
>  	const char *name;
> -	char *default_trigger;
> +	const char *default_trigger;
>  	unsigned 	gpio;
>  	u8 		active_low;
>  };
> -- 
> 1.5.4.3
>