[RFC PATCH] of_gpio: implement of_get_gpio_flags()

Trent Piepho tpiepho at freescale.com
Sat Jul 26 18:26:01 EST 2008


On Fri, 25 Jul 2008, Anton Vorontsov wrote:
>
> The name seems a bit unfortunate though, because one could read the
> function as it gets gpio flags only (though, we might implement
> this instead, but this way average driver will end up with parsing
> gpios = <> twice).

It is kind of a confusing name.  I'd be tempted to just change of_get_gpio,
it's a new function and it's only called from four places so it's not that
hard to change.



More information about the Linuxppc-dev mailing list