sfx.c driver build failure

Ingo Molnar mingo at elte.hu
Fri Jul 25 17:32:25 EST 2008


* Stephen Rothwell <sfr at canb.auug.org.au> wrote:

> On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:
> >
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> > 
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
> 
> Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around 
> topology_core_siblings() breakage" in linux-next (from the cpus4096 
> tree) comments out the offending lines ...  With the comment "the 
> topology API is a mess right now".

there's a patch from Mike Travis that solves it all from grounds up and 
which approach has the ack of Rusty as well, but it's not fully tested 
through yet - i will get to it later today.

	Ingo



More information about the Linuxppc-dev mailing list