[PATCH 4/6] kvmppc: magic page hypercall - host part

[Tony Breeds]

On Wed, Jul 23, 2008 at 10:36:45AM +0200, ehrhardt at linux.vnet.ibm.com wrote:

Hi Christian,

>  long kvm_arch_dev_ioctl(struct file *filp,
>                          unsigned int ioctl, unsigned long arg)
>  {
> -	return -EINVAL;
> +	long r = -EINVAL;
> +
> +	switch (ioctl) {
> +	case KVM_GET_PPCPV_MAGICPAGE_SIZE:
> +		r = -EINVAL;

Not needed you set it on the declaration.

> +		if (arg)
> +			goto out;
> +		r = 1024;

Ummm what does 1024 represent? can it me #defined? or at least add a
comment.

> +		break;
> +	default:
> +		r = -EINVAL;

Not needed you set it on the declaration.

> +	}
> +out:
> +	return r;
>  }

Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!