[PATCH] Don't panic when EEH_MAX_FAILS is exceeded

Sean MacLennan smaclennan at pikatech.com
Mon Jul 21 04:58:58 EST 2008


On Sun, 20 Jul 2008 11:28:36 -0700
"Mike Mason" <mmlnx at us.ibm.com> wrote:

> This patch changes the EEH_MAX_FAILS action from panic to printing an
> error message.  Panicking under under this condition is too harsh.
> Although performance will be affected and the device may not recover,
> the system is still running, which at the very least, should allow
> for a more graceful shutdown.  The panic() is now wrapped in a DEBUG
> statement for development purposes.  The patch also removes the
> msleep() within a spinlock, which is not allowed.

Why can you not msleep within a spinlock? And when was this change
brought in?

Cheers,
   Sean



More information about the Linuxppc-dev mailing list