[PATCH 1/6] crypto: talitos - remove calls to of_node_put

Kim Phillips kim.phillips at freescale.com
Thu Jul 17 09:21:46 EST 2008


From: Lee Nipper <lee.nipper at freescale.com>

Remove of_node_put calls since there is no corresponding of_node_get.
This patch prevents an exception when talitos is loaded a 2nd time.
This sequence: modprobe talitos; rmmod talitos; modprobe talitos
causes this message: "WARNING: Bad of_node_put() on /soc8349 at e0000000/crypto at 30000".

Signed-off-by: Lee Nipper <lee.nipper at freescale.com>
Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
---
this patchseries contains various fixes to the talitos driver, mainly as a
result of Lee's stress testing.

 drivers/crypto/talitos.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index b11943d..01e6595 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -1466,9 +1466,6 @@ static int talitos_probe(struct of_device *ofdev,
 		goto err_out;
 	}
 
-	of_node_put(np);
-	np = NULL;
-
 	priv->head_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
 				  GFP_KERNEL);
 	priv->tail_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
@@ -1559,8 +1556,6 @@ static int talitos_probe(struct of_device *ofdev,
 
 err_out:
 	talitos_remove(ofdev);
-	if (np)
-		of_node_put(np);
 
 	return err;
 }
-- 
1.5.6




More information about the Linuxppc-dev mailing list