[PATCH] Fix wrong 'no interrupt' handling in of_i2c

Sean MacLennan smaclennan at pikatech.com
Thu Jul 17 08:15:56 EST 2008


On Sat, 28 Jun 2008 13:16:16 -0600
"Grant Likely" <grant.likely at secretlab.ca> wrote:

> On Sat, Jun 28, 2008 at 12:31 PM, Wolfram Sang
> <w.sang at pengutronix.de> wrote:
> > If an I2C device node does not specify an interrupt, the .irq
> > member of the board_info struct was set to -1. This caused crashes
> > on following irq_dispose_mappings. Leave it NO_IRQ as returned from
> > irq_of_parse_and_map. (Suggesting -1 as 'i2c-no-irq' used to be a
> > bug in linux/i2c.h.)
> >
> > Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> 
> Acked-by: Grant Likely <grant.likely at secretlab.ca>
> 

I just hit this while trying to get the at24 driver working. So:

Acked-by: Sean MacLennan <smaclennan at pikatech.com>

Cheers,
   Sean



More information about the Linuxppc-dev mailing list