[PATCH] of: i2c: improve last resort compatible entry selection

Jochen Friedrich jochen at scram.de
Tue Jul 15 20:44:42 EST 2008


Hi Anton,

> Since no sane driver will ever match specific devices, what we want is
> to select most generic option (last). Then driver may call
> of_device_is_compatible() if it is really interested in details.

My original intention was to have alias entries for specific devices in the
i2c device drivers. Later, Jean decided to only have the most generic names
in there (like in http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=drivers/media/video/tvaudio.c;h=c77914d99d15c5972c94e9763a08b5789098e90a;hp=6f9945b04e1f2bcd676f0ed8dc910994b29ed300;hb=ae429083efe996ca2c569c44fd6fea440676dc33;hpb=60b129d7bfa3e20450816983bd52c49bb0bc1c21)
So your patch is correct.

> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>

Acked-by: Jochen Friedrich <jochen at scram.de>

Thanks,
Jochen



More information about the Linuxppc-dev mailing list