[RFC] [PATCH] task_pt_regs for powerpc systems
Benjamin Herrenschmidt
benh at kernel.crashing.org
Mon Jul 14 08:40:03 EST 2008
On Mon, 2008-07-14 at 08:32 +1000, Paul Mackerras wrote:
> Srinivasa D S writes:
>
> > task_pt_regs() macro defines pt_regs for the given task, this macro is
> > currently not defined for powerpc arch. We need this macro for
> > upcoming utrace features.
> > Below attached patch defines this macro for powerpc arch. Please let
> > me know your comments on this.
>
> > +#define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.regs)
>
> The cast is unnecessary since tsk->thread.regs is already a struct
> pt_regs *. Also note that tsk->thread.regs will be NULL for a kernel
> thread.
Hrm.. I stuck that one in powerpc master, but not yet in next. Wonder if
I should back it out, sounds like a minor issue.
Ben.
More information about the Linuxppc-dev
mailing list