[PATCH -next-20080709] fixup stop_machine use cpu mask vs ftrace

Ingo Molnar mingo at elte.hu
Fri Jul 11 17:46:03 EST 2008


* Milton Miller <miltonm at bga.com> wrote:

> Hi Rusty, Ingo.
> 
> Rusty's patch [PATCH 3/3] stop_machine: use cpu mask rather than magic 
> numbers didn't find kernel/trace/ftrace.c in -next, causing an 
> immediate almost NULL pointer dereference in ftrace_dynamic_init.

Rusty - what's going on here? Please do not change APIs like that, which 
cause code to crash. Either do a compatible API change, or change it 
over in a way that causes clear build failures, not crashes.

	Ingo



More information about the Linuxppc-dev mailing list