[PATCH] [POWERPC] 52xx: add missing MSCAN FDT nodes for TQM52xx

[David Gibson]

On Wed, Jul 02, 2008 at 11:56:40AM +0200, Wolfgang Grandegger wrote:
> This patch adds the still missing FDT nodes for the MSCAN devices for
> the TQM52xx modules.
>
> Signed-off-by: Wolfgang Grandegger <wg at grandegger.com>
> ---
> arch/powerpc/boot/dts/tqm5200.dts |   16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
> ===================================================================
> --- linux-2.6-galak.orig/arch/powerpc/boot/dts/tqm5200.dts
> +++ linux-2.6-galak/arch/powerpc/boot/dts/tqm5200.dts
> @@ -70,6 +70,22 @@
> 			fsl,has-wdt;
> 		};
>
> +		can at 900 {
> +			compatible = "fsl,mpc5200-mscan";
> +			cell-index = <0>;

What shared resource are these cell-index values used to index into?
Because cell-index is so freqeuntly misunderstood, I strongly
recommend putting a comment describing this.

> +			interrupts = <2 17 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +			reg = <0x900 0x80>;
> +		};
> +
> +		can at 980 {
> +			compatible = "fsl,mpc5200-mscan";
> +			cell-index = <1>;
> +			interrupts = <2 18 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +			reg = <0x980 0x80>;
> +		};
> +
> 		gpio at b00 {
> 			compatible = "fsl,mpc5200-gpio";
> 			reg = <0xb00 0x40>;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson