[PATCH v3] ibm_newemac: Fixes kernel crashes when speed of cable connected changes

Jeff Garzik jeff at garzik.org
Fri Jul 4 22:17:30 EST 2008


Stefan Roese wrote:
> From: Sathya Narayanan <sathyan at teamf1.com>
> 
> The descriptor pointers were not initialized to NIL values, so it was
> poiniting to some random addresses which was completely invalid. This
> fix takes care of initializing the descriptor to NIL values and clearing
> the valid descriptors on clean ring operation.
> 
> Signed-off-by: Sathya Narayanan <sathyan at teamf1.com>
> Signed-off-by: Stefan Roese <sr at denx.de>
> ---
>  drivers/net/ibm_newemac/core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 5d2108c..ca63fa0 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2719,6 +2719,8 @@ static int __devinit emac_probe(struct of_device *ofdev,
>  	/* Clean rings */
>  	memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor));
>  	memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor));
> +	memset(dev->tx_skb, 0, NUM_TX_BUFF * sizeof(struct sk_buff *));
> +	memset(dev->rx_skb, 0, NUM_RX_BUFF * sizeof(struct sk_buff *));
>  

applied to 2.6.26





More information about the Linuxppc-dev mailing list