New fsl device bindings file

Grant Likely grant.likely at secretlab.ca
Fri Jul 4 14:26:01 EST 2008


On Thu, Jul 03, 2008 at 01:38:17PM -0500, Kumar Gala wrote:
>
> On Jul 3, 2008, at 1:34 PM, Grant Likely wrote:
>
>> On Thu, Jul 3, 2008 at 12:28 PM, Scott Wood <scottwood at freescale.com> 
>> wrote:
>>> Documentation/powerpc/device-tree/fsl/cpm.txt
>>> Documentation/powerpc/device-tree/fsl/cpm/uart.txt
>>> Documentation/powerpc/device-tree/fsl/tsec.txt
>>> Documentation/powerpc/device-tree/interrupts.txt
>>> Documentation/powerpc/device-tree/dtb.txt
>>
>> May I suggest moving it to Documentation/of-bindings/ instead?  Some
>> of these bindings (granted, not the fsl ones) will be used by
>> non-powerpc platforms (sparc, microblaze).
>
> I think the powerpc bindings should still be under Docs/powerpc/of- 
> bindings/
>
> It makes it cleaner in that each arch/sub-arch maintainer can maintain  
> Docs/<arch>/of-bindings and we can all vet changes to Docs/of-bindings

Personally, I think it would still be better to keep everything in one
place, even if large parts of it are arch specific.  I think it would
encourage people to look across architecture boundaries when looking for
examples of how to document device tree bindings.  It would also
discourage accidental duplication for parts that end up being used in
more than one architectures (ie. spi and i2c devices).  Not everyone is
going to be well versed on the rules of what bindings should be arch
specific and what should go in the common dir.  It will make everyone's
life easier if there is only one place to look.

(oh, and I think the subdirectories by manufacturer is a good layout).

g.



More information about the Linuxppc-dev mailing list