[PATCH 1/2] Convert i2c-mpc from a platform driver into a of_platform driver, V3

[Scott Wood]

On Mon, Jun 30, 2008 at 02:34:13PM -0400, Jon Smirl wrote:
> +		result = request_irq(i2c->irq, mpc_i2c_isr,
> +							IRQF_SHARED, "i2c-mpc", i2c);

That's a rather excessive indentation of the continuation line -- it
looks like it was aligned using 4-character tabs.  It's best to use
spaces for alignment (after using tabs to reach the indentation level),
especially if you're using a non-standard tab size.

>  static int __init fsl_i2c_init(void)
>  {
> -	return platform_driver_register(&fsl_i2c_driver);
> +	int rv;
> +
> +	rv = of_register_platform_driver(&mpc_i2c_driver);
> +	if (rv)
> +		printk(KERN_ERR DRV_NAME 
> +		" of_register_platform_driver failed (%i)\n", rv);

Please align the continuation line with the first parameter.

-Scott