[PATCH 1/2] firewire: endianess fix
Stefan Richter
stefanr at s5r6.in-berlin.de
Thu Feb 28 19:41:20 EST 2008
Benjamin Herrenschmidt wrote:
> Do we have the workaround for the old Apple UniNorth in the new FW OHCI
> driver (for selfID swapping iirc ?)
According to ohci1394.c, it selfIDs and headers of incoming packets are
not byte-swapped by the old Apple Uninorth FireWire part. And no,
firewire-ohci doesn't have the workaround yet.
It should be trivial to copy'n'paste ohci1394's workaround into fw-ohci,
but it would be good if someone could test before and after.
BTW, since that code is touched everytime a packet is received, we
should enclose such a workaround in #ifdef CONFIG_PPC_PMAC &&
CONFIG_PPC32, shouldn't we? (As a second step after adding the workaround.)
--
Stefan Richter
-=====-==--- --=- ===--
http://arcgraph.de/sr/
More information about the Linuxppc-dev
mailing list