[patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

Greg KH greg at kroah.com
Thu Feb 21 05:29:53 EST 2008


On Wed, Feb 20, 2008 at 10:07:01AM -0800, David Brownell wrote:
> On Wednesday 20 February 2008, Greg KH wrote:
> > > ?Greg> Can you move the files under the hcd/ subdir
> > 
> > Oops, I ment "host/" not, "hcd/".
> > 
> > > Sorry, I don't think that's a good idea as the hardware can do
> > > peripheral as well, and as you can see in patch 4, a gadget driver is
> > > on it's way.
> > 
> > Ok, that's fine, why can't the gadget stuff go into the gadget/
> > directory then also? ?As this device is a host controller, it makes
> > sense to me to keep it in the host-controller subdirectory.
> 
> FWIW we did the same thing with drivers/usb/musb (for the Mentor
> highspeed OTG core) ... the basic issue is that the host and
> peripheral sides of the hardware aren't split like that.  There
> would be lots of code sharing (FIFO access, IRQ handling, DMA,
> initialization, come quickly to mind) between HCD and gadget
> sides.  Enough that trying to create an artificial split between
> those -- and let it coordinate properly in OTG modes -- seemed
> like a waste of effort.

Ah, but I don't see that directory in the current tree on kernel.org, so
I haven't see this kind of driver before :)

And isn't the whole OTG code base still in flux as to where it lives?
Or so I thought a thread last week showed.

thanks,

greg k-h



More information about the Linuxppc-dev mailing list