[PATCH] [POWERPC] 4xx: Fix Haleakala PCIe compatibility problem in dts

Josh Boyer jwboyer at linux.vnet.ibm.com
Thu Feb 21 05:08:02 EST 2008


On Wed, 20 Feb 2008 14:16:53 +0100
Stefan Roese <sr at denx.de> wrote:

> > > The 405EX and 405EXr are identical exept that the 2nd PCIe and the
> > > 2nd EMAC interfaces are missing.
> >
> > Does ppc405ex_pciex_core_init need to grow some logic to detect 405ex
> > from 405exr and return the correct number of ports then?  It
> > unconditionally returns 2 today.
> 
> Yes, this could be done. Right now it works because the 405EXr board 
> (Haleakala) only instantiates one PCIe device in the dts.
> 
> A simple solution would be to just do a PVR check. Would this be acceptable?

Looking more at the code, it seems like it's really not needed.
Essentially the only thing that is "wrong" is that we allocate an extra
structure that goes unused.

As long as the DTS file doesn't list a second bogus port, things work
fine.  So I'm inclined to take your patch as-is.

josh



More information about the Linuxppc-dev mailing list