[PATCH] powerpc: Marvell 64x60 EDAC platform devices setup

[Stephen Rothwell]

Hi Dave,

On Mon, 11 Feb 2008 15:50:23 -0700 Dave Jiang <djiang at mvista.com> wrote:
>
> +static int __init mv64x60_edac_pdev_init(struct device_node *np,
> +                                         int id,
> +                                         int num_addr,
> +                                         char *pdev_name)

The pdev_name is just passed to platform_device_register_simple() which
take a "const char *", so make pdev_name consta as well, please.

> +static int __init mv64x60_pci_fixup(struct device_node *np)
> +{
> +	struct resource res;
> +	void __iomem *pci_serr;
> +	int ret;
> +
> +	ret = of_address_to_resource(np, 1, &res);
> +	if (ret)
> +		return ret;
> +
> +	pci_serr = ioremap(res.start, res.end - res.start + 1);

Why not use of_iomap(np, 1), then you don't need res.

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080212/1b4ed2d0/attachment.pgp>