[PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

Stephen Rothwell sfr at canb.auug.org.au
Tue Feb 5 01:48:21 EST 2008


On Mon, 4 Feb 2008 16:46:17 +0300 Anton Vorontsov <avorontsov at ru.mvista.com> wrote:
>
> On Tue, Feb 05, 2008 at 12:13:18AM +1100, Stephen Rothwell wrote:
> > 
> > If you don't care about the returned length (argument three to
> > of_get_property), you can just pass NULL (and dispense with "size").
> > Also, what happens if prop is NULL?
> 
> All this was in the old code already, I just didn't fix that.

I appreciate that, but it did need fixing.

> - - - -
> From: Anton Vorontsov <avorontsov at ru.mvista.com>
> Subject: [POWERPC] qe_lib: fix few fluffy negligences
> 
> One is intoduced by me (of_node_put() absence) and another was
> present already (not checking for NULL).
> 
> Found by Stephen Rothwell.
> 
> Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>

Acked-by: Stephen Rothwell <sfr at canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell                    sfr at canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20080205/c96db3ce/attachment.pgp>


More information about the Linuxppc-dev mailing list